Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Consider moving CSS file into JS

See original GitHub issue

Moving all the CSS rules into JS to be applied at the time Terminal.open is called would simplify use of the library and prevent people experiencing issues like this https://github.com/xtermjs/xterm.js/issues/3045. Overriding would also still be possible via !important.

This would need some verification work after (checking VS Code still works) and documentation updates.

Issue Analytics

State:
Created 3 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

2reactions

Tyriarcommented, Sep 17, 2020

Sounds good, let’s close this out with as designed then since we already call it out pretty prominently in the readme 👌

1reaction

jerchcommented, Sep 16, 2020

@Tyriar Thb I dont like this idea for a simple reason - CSS is there for styling, we should not move things that can be styled with predefined rules away from the domain, that is meant for that purpose. (I’d go a step further and actually think that terminal themes should be in CSS as well.)

If ppl have issues to get CSS correctly loaded, then either our documentation is bad in this regard, or they should learn how to correctly embed CSS. Sorry if this sounds harsh, but for me moving away from CSS and doing everything in JS is a clear antipattern.