question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Hard-coded CSS mangles RTL layouts

See original GitHub issue

#701 documents ongoing work toward full support for RTL; however, a separate, related issue is that xterm.css includes hard-coded left and right rules which don’t display correctly on RTL pages:

image

Details

  • Browser and browser version: FF/Mac and Chrome/Mac, current versions
  • OS version: macOS High Sierra
  • xterm.js version: 3.2.0

Steps to reproduce

  1. Set dir="rtl" on the demo’s index.html.
  2. Load the demo.

OBSERVE: The page appears to be blank because everything is -9999em to the left. EXPECTED: The CSS shouldn’t assume left-to-right document layout.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:15 (15 by maintainers)

github_iconTop GitHub Comments

1reaction
FGaspercommented, Apr 16, 2018

Yeah, I see the fix in 3.3; I’ll see if I can bisect later to determine what happened.

0reactions
Tyriarcommented, Apr 19, 2018

@FGasper I only ever use npm run watch which I know completely rebuilds lib/ at least.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Building Multi-Directional Layouts - CSS-Tricks
There are some new features in CSS that can assist us with building layouts for different directions and languages with ease.
Read more >
Right-to-left Styling - RTL Styling 101
An extensive guide on how to style for RTL in CSS. ... Based on the design for both LTR and RTL layouts, there...
Read more >
Right-to-left (RTL) languages - styling considerations
When a website is viewed in one of these languages, content is displayed in a mirrored layout. Some styles need to be optimised...
Read more >
direction - CSS: Cascading Style Sheets - MDN Web Docs
The direction CSS property sets the direction of text, table columns, and horizontal overflow. Use rtl for languages written from right to ...
Read more >
Supporting "right to left" (RTL) languages | Working with CSS
Inline text should flow automatically as long as the theme sets the language direction of the document through the "page.tpl.php" template.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found