Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Resolve perf regression from OptionsService.options

See original GitHub issue

https://github.com/xtermjs/xterm.js/pull/3448#issuecomment-969404249

This PR creates a significant perf decrease in common modules, which have to ask option service for options (e.g. Inputhandler.print alone decreases by ~20%). Reason behind: https://github.com/xtermjs/xterm.js/blob/0bc02d6838a2a75048001003617bf172efcf622b/src/common/services/OptionsService.ts#L98-L107

Fix: dont use getter/setter in fast path code.

We could expose the raw object internally?

Issue Analytics

State:
Created 2 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

Tyriarcommented, Jan 5, 2022

@jaminthorns thanks for the report, you spotted a pretty nasty regression 🎉

0reactions

jaminthornscommented, Jan 4, 2022

@Tyriar My terminal.integrated.gpuAcceleration was unset, so it was defaulting to auto. After playing around with that setting while I had an integrated terminal open, I discovered the actual problem, which seems to be with VS Code. I opened a ticket for that here: https://github.com/microsoft/vscode/issues/140128

Looks like this issue is unrelated to my problem.