Should we use a monorepo structure for addons?

I’m beginning to think it will be much easier to manage the addons if we just include them as part of the xterm repo (in <root>/addons/<addon>?) but still upload them separately to npm. That way we could test them all as part of our CI to ensure breakages don’t happen across versions, like what might have happened to ligatures recently. The main downsides I see are that issues will all remain in the 1 repo (maybe that’s good?) and they won’t be as good examples of what an external addon should be.

[mofux]

I see, that’s fine with me 👍 Let’s go with #2164 then - and thanks for all the effort you are putting into the whole restructuring / refactoring ❤️

[Tyriar]

I ended up removing --modules-folder as it didn’t work the way I expect it to, when running yarn in the addon ../../node_modules would get cleared out and replaced with just ws and @types/ws, I was expected it to be additive but it makes sense now that I think about it. Instead of trying to duplicate the dependencies right now everything just uses the root node_modules and addon dependencies become devDependencies of the root package.json (just ws and @types/ws for attach testing).

Each addon only has a single npm script:

"prepublishOnly": "../../../node_modules/.bin/tsc -p src"

So npm publish will always do a build beforehand, another complication with sharing the modules or duplicating them in the addons is that the typescript versions could differ and cause confusion. They all share the same primary dependencies anyway so sharing makes sense (puppeteer, mocha, typescript, etc.).