question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Privateer capture while defending message

See original GitHub issue

Resulting to-do list, moved from discussion below:

  • Icons on capture should show capturing unit - war - victim.
  • Any destroy message for the same battle should be suppressed.
  • Capture active only on attack (thanks @ravignir ).
  • plunderFromDamage - mention ‘ingame civilopedia’, and maybe this issue as sources
  • plunderFromDamage calls - make offensive only or defensive/offensive controlled by unique
  • toInt() earlier so plunder message won’t show fractional Gold
  • Test thoroughly
  • Update wiki in case #4698 gets merged No new unique after all.

image

… that was one and the same Trireme.

Question: Does Civ5 allow Privateers to capture while defending? To-do: Check that message. Defender wins - so far OK. But if it results in capture the word ‘kill’ isn’t appropriate and we should consider special-casing this. Of course only if the answer above is ‘yes’.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:11 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
ravignircommented, Jul 31, 2021

Stuff I noticed while coding:

* The unit 'captured' by a Privateer has nothing common with the defeated unit except the BaseUnit name, it's created from scratch with always zero promotions, 0 XP and 50% health. That's fine - but while we're at it: @ravignir - does this match Civ5?

* The "plundered" Gold is magicked from thin air, and not subtracted from the victim's reserves. Same question.

yes and yes.

0reactions
SomeTroglodytecommented, Jul 31, 2021

Stuff I noticed while coding:

  • The unit ‘captured’ by a Privateer has nothing common with the defeated unit except the BaseUnit name, it’s created from scratch with always zero promotions, 0 XP and 50% health. That’s fine - but while we’re at it: @ravignir - does this match Civ5?
  • The “plundered” Gold is magicked from thin air, and not subtracted from the victim’s reserves. Same question.
Read more comments on GitHub >

github_iconTop Results From Across the Web

Letter of marque - Wikipedia
A letter of marque and reprisal was a government license in the Age of Sail that authorized a private person, known as a...
Read more >
Unleash the Privateers! | Proceedings - U.S. Naval Institute
Privateering is not piracy—there are rules and commissions, called letters of marque, that governments issue to civilians, allowing them to capture or destroy ......
Read more >
Congress authorizes privateers to attack British vessels
Any goods captured by the privateer were divided between the ship's owner and the government that had issued the letter. Congress informed American...
Read more >
Privateers - NCpedia
Privateers were privately owned and manned ships authorized by their governments during wartime to attack and capture enemy shipping vessels.
Read more >
Privateers in the American Revolution - National Park Service
If a privateer captured an enemy ship (known as a prize), an admiralty prize court had to approve the seizure. Then, the proceeds...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found