question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

I am thinking I want to port this lib to Typescript and add some more integrations namely Prometheus. Maybe finally clean up somethings on the Metrics objects, such as toJson() being the primary manner of getting data when half the time it doesn’t return JSON.

As I am basically the only one care and feeding this lib, I will leave this issue open for a while and see if anyone has comments and see if I have time to start this process.

Closes #32

In the process maybe we can get some integration tests up and running so that PRs like dependency auto bumps can be streamlined and we can make sure we stay up to date to prevent security issues.

I think porting to TS can be done 1 package at a time starting with core.

I am going to CC anyone who has ever contributed for visibility:

CC: @felixge, @mantoni, @Qard, @oliverzy, @csabapalfi, @dohse, @anacasner, @horte, @bnoordhuis, @tuckbick, @tlisonbee, @joeybaker, @hugebdu, @avolfson, @arlolra, @OlegIlyenko

Issue Analytics

  • State:open
  • Created 3 years ago
  • Reactions:4
  • Comments:12 (7 by maintainers)

github_iconTop GitHub Comments

4reactions
dyladancommented, Jun 24, 2020

@fieldju we would definitely be happy to have your help on opentelemetry js. While true that the metrics sdk is only seeing about 1000 downloads weekly right now, it is still in beta phase and is somewhat incomplete. I would say if you are going to deprecate this library in favor of otel, you should likely familiarize yourself with the state of the project and consider waiting until we launch GA toward the end of the summer before beginning to actively push your users to it. We may also be able to work on some sort of compatibility bridge similar to what we have for opentracing on the trace side that would allow your users to take advantage of opentelemetry in stages without making too many code changes all at once.

does open-telemetry have gauges, timers, meters I am only really seeing counters here: https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-api/src/metrics/Meter.ts?

Metrics is under active development right now. You can see the full details of what will be supported in the spec here. Without knowing exactly how you define the difference between a gauge and a meter it is difficult to answer exactly, but you are probably looking for the ValueRecorder and the ValueObserver.

There is currently not support or specification for timers, but I believe there has been active discussion in the specification around that.

2reactions
Qardcommented, Jun 24, 2020

I would vote leave it as-is and encourage users to migrate. There are some major users that I’m sure would appreciate not needing to move so immediately and hopefully not needing to move twice. (once to v2 and then again to otel)

Read more comments on GitHub >

github_iconTop Results From Across the Web

RFC 7568: Deprecating Secure Sockets Layer Version 3.0
... The Secure Sockets Layer version 3.0 (SSLv3), as specified in RFC 6101, ... (TLS) 1.2 (RFC 5246), are considerably more secure and...
Read more >
Deprecating Secure Sockets Layer Version 3.0 (RFC 7568)
The Secure Sockets Layer version 3.0 (SSLv3), as specified in RFC 6101, is not sufficiently secure. This document requires that SSLv3 not be...
Read more >
RFC Series Residential Concealed Pendent Sprinklers
RFC Series Residential Concealed Pendent Sprinklers · Style List: Pendent · K Factor: 3.0 (43), 4.3 (62), 4.9 (71), 5.8 (84), 7.6 (109) ......
Read more >
RFC | etcd
Version v3.1 of the documentation is no longer actively maintained. The page that you are viewing is the last archived version.
Read more >
SAP Connector for Microsoft .NET 3.0
NET 3.0 (NCo 3.0) allows developers to use BAPIs and remote-enabled function ... NET components from any ABAP application by implementing an RFC...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found