Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Issue with ember 3.27

See original GitHub issue

Hey 👋🏻 When I’m using ember-modal-dialog with last ember release (3.27.0) I have the following error :

index.js:460 Uncaught TypeError: Cannot create property 'Symbol(INIT_FACTORY)' on string 'my-modal-dialog-destination'

After some investigations it seems related to the way the id of modal destination is injected into modal-dialog service.

The error is throw here : https://github.com/yapplabs/ember-modal-dialog/blob/master/addon/components/modal-dialog.js#L22

I’m not expert in how ember injection works, but it seems the { instantiate: false } option from here is ignored :

https://github.com/yapplabs/ember-modal-dialog/blob/master/addon/initializers/add-modals-container.js#L40-L44

I tested on ember 3.26.1 & don’t reproduce…

I had a look to 3.27.0 release note & don’t see any changes related to this 🤔

Issue Analytics

State:
Created 2 years ago
Comments:6 (4 by maintainers)

Top GitHub Comments

2reactions

lukemeliacommented, May 17, 2021

Workaround released in v3.0.3

0reactions

lukemeliacommented, May 6, 2021

Well articulated, thanks @romgere!

Top Results From Across the Web

Ember 3.27 Released

Ember.js 3.27 is an incremental, backwards compatible release of Ember with bug fixes, performance improvements, and deprecations. For a full ...

[Bug] Compat issue with current and pre-3.27.0 versions of ember ...

I built a new addon with 3.27.2 and found that it did not work in any apps that use ember-source prior to 3.27.0...

Ember.computed.alias is not a function - Stack Overflow

I'm upgrading a project from 3.26 to 3.27 using ember-cli-update, and then this error started happening, As I could see the error is...

Upgrading Discourse to Ember 4 - dev

Please note that this topic is a roadmap, and a… ... Ember 3.26 → Ember 3.27 (Part 2 - RenderTemplate ) Ember 3.26...

@ember/test-helpers | Yarn - Package Manager

v0.5.17 (2015-12-07) ... Closed issues: Tests fail for latest beta/canary #126; Can no longer override registry in acceptance tests #124. Merged pull requests:....