[Bug?]: `fs/promises` is detected as a dependency

Self-service

• I’d be willing to implement a fix

Describe the bug

Any package which uses fs/promises is unable to import as yarn asks this to be listed in it’s dependencies.

Error: builder-util tried to access fs, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: fs (via "fs/promises")

To reproduce

await packageJsonAndInstall({});

await expect(node(`require.resolve('fs/promises')`)).resolves.toBeTruthy();

You can also go into any repo running yarn@3, make a file with require('fs/promises') and run yarn node file.js

Error: Your application tried to access fs, but it isn't declared in your dependencies; this makes the require call ambiguous and unsound.

Required package: fs (via "fs/promises")

Environment

System: OS: Linux 4.15 Ubuntu 16.04.7 LTS (Xenial Xerus) CPU: (6) x64 AMD FX™-6100 Six-Core Processor Binaries: Node: 12.22.5 - /tmp/xfs-38ba3067/node Yarn: 3.0.1 - /tmp/xfs-38ba3067/yarn npm: 6.14.14 - ~/.nvm/versions/node/v12.22.5/bin/npm

Additional context

No response

[merceyz]

Node 12.22.5 doesn’t report fs/promises as a builtin module

$ node -p "require('module').builtinModules" | grep fs
  'domain',            'events',              'fs',

I found this hard to reproduce in the sherlock shell, I’d always get

You were missing an install and a expect to assert what should happen, I’ve updated your repro but it wont reproduce as it runs with Node 14 which does report it as a builtin module

$ node -p "require('module').builtinModules" | grep fs
  'fs',                'fs/promises',         'http',

[yarnbot]

We couldn’t reproduce your issue (all the assertions passed on master).