[Bug] PnPify in Visual Studio Code does not support "Go to Definition"

• I’d be willing to implement a fix

Describe the bug

When using the PnPify workflow in Visual Studio Code, attempting to “Go to Definition” of a dependency results in VS Code attempting, and failing, to open a source file from inside a zipped package in the cache:

Unable to open 'index.d.ts': Unable to read file (Error: File not found (c:\Users\dallo\devroot\tmp\my-app\.yarn\cache\@types-react-npm-16.9.19-21809ae185-1.zip\node_modules\@types\react\index.d.ts)).

To Reproduce

(This isn’t exactly minimal since I don’t think Create React App is part of the issue, but it’s at least very simple to reproduce, and I don’t have time to figure out how to create a project without a template right now. Would appreciate anyone with more context helping break it down a little more)

1. Create an app with Create React App as described in the CRA docs:

npx create-react-app my-app --template typescript

1. Follow the instructions to enable PnPify in Visual Studio Code: https://yarnpkg.com/advanced/editor-sdks#vscode
2. In App.tsx, try to “Go to Definition” on the React package.

Screenshots

Environment if relevant (please complete the following information):

• OS: Windows 10, build 18362.592
• Node v13.7.0
• Yarn v2.0.0-rc.27

Additional context

Looks like the root of the issue is that it’s trying to go inside a zip file.

[skeate]

Thanks for that link, though it’s a little hard to understand without an example given. But I don’t want to derail this issue with a tangent.

Do you agree that it’s an issue, or should editors be able to access $$virtual somehow?

Also, aside for anyone else finding this thread who wants a fix now: yarn unplug <pkg>

[arcanis]

Do you agree that it’s an issue, or should editors be able to access $$virtual somehow?

It’s an issue in that I don’t expect editors to support the $$virtual file pattern as their encoding is a bit of a Yarn implementation detail, but I can’t find any better tool we can use at the moment.

Closing this issue as there’s nothing actionable on our side at the moment (for people reaching this, please upvote https://github.com/microsoft/vscode/issues/75559 to show your interest to the VSCode team).