[Bug?]: `yarn bin` reports wrong bin from `installConfig.hoistingLimits` workspace (`nodeLinker: node-modules`)

Self-service

• I’d be willing to implement a fix

Describe the bug

I have a few workspaces, they’re depending on @graphql-codegen/cli which contributes a graphql-codegen bin script.

One of the workspaces zapier has installConfig.hoistingLimits set to workspaces, the other workspaces don’t have this set.

When I run yarn bin graphql-codegen in one of the other workspaces it gives a path under the zapier workspace.

Instead I would expect it to give the path not from that workspace.

The problem this causes is that different copies of other packages end up getting imported within the same node process (e.g. graphql is particularly fragile for this).

To reproduce

const fs = require('fs').promises;

await fs.writeFile('.yarnrc.yml', 'nodeLinker: node-modules');

await packageJsonAndInstall({
  "name": "root",
  "workspaces": [
    "packages/*"
  ],
  "dependencies": {
    "rimraf": "^2.0.0"
  },
});

await fs.mkdir('packages/nohoist', { recursive: true });
await fs.writeFile("packages/nohoist/package.json", `{
  "dependencies": {
    "rimraf": "^2.0.0"
  },
  "name": "nohoist",
  "installConfig": {
    "hoistingLimits": "workspaces"
  }
}`);

await yarn(`install`);

const rootRimrafPath = await yarn(`bin`, `rimraf`)
const nohoistRimrafPath = await yarn(`workspace`, `nohoist`, `bin`, `rimraf`);

expect(rootRimrafPath).not.toEqual(nohoistRimrafPath);

Environment

System:
    OS: macOS 12.6
    CPU: (10) arm64 Apple M1 Max
  Binaries:
    Node: 16.14.0 - /private/var/folders/jq/3x3ddtjx3rb9nwy79zxfwnj00000gn/T/xfs-6ab2aa01/node
    Yarn: 3.2.4 - /private/var/folders/jq/3x3ddtjx3rb9nwy79zxfwnj00000gn/T/xfs-6ab2aa01/yarn
    npm: 8.3.1 - ~/.n/bin/npm

Additional context

No response

[bradleyayers]

Please provide reproduction steps

@larixer sure thing, I’ve added a Sherlock reproduction.

[larixer]

@bradleyayers Great, thank you very much!