question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support sending spans in batches

See original GitHub issue

The Zipkin Kafka collector supports receiving batches of spans instead of single spans after https://github.com/openzipkin/zipkin/pull/995. However, having a py_zipkin user implement batching solely in the transport_handler seems like it’d be too difficult on their part.

Maybe we could support having ZipkinLoggingContext take a batch_size param that defaults to something large but sane (20?), then in log_spans we could call transport_handler with a list of thrift-encoded spans as opposed to a single span at a time.

@kaisen, thoughts?

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
dmitry-prokopchenkovcommented, Jul 1, 2017

@kaisen, @bplotnick What about this? AFAIK Zipkin serer can process batch spans. At least we might modify log_spans to send root span and self.log_handler.client_spans together. What do you think? I could give a try on this.

0reactions
dmitry-prokopchenkovcommented, Aug 1, 2017

@bplotnick just a reminder, this can be closed

Read more comments on GitHub >

github_iconTop Results From Across the Web

Support batch of spans in storage writer interface #2142
I would like to propose to change it to work on a batch of spans instead. The reason being OTEL exporter accepts a...
Read more >
BatchSpanProcessor in opentelemetry::sdk::trace - Rust
Batch span processors need to run a background task to collect and send spans. Different runtimes need different ways to handle the background...
Read more >
The life of a span. In the OpenTracing realm, as well as in…
Compact span batch sent from Jaeger Java Client to Jaeger Agent ... Based on the service name, our trace is then found and...
Read more >
Performance Tuning Guide
In general, span batches are processed as soon as they are placed in the server queue and will block a worker until the...
Read more >
Optimizing OpenTelemetry's Span Processor for High ...
Learn how we used benchmarking to find a batch span processor that ... OpenTelemetry supports three data sources: traces, metrics, and logs.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found