Incompatible with pip 18.1

$ pip-faster install astpretty
Traceback (most recent call last):
  File "/tmp/h/venv/bin/pip-faster", line 11, in <module>
    sys.exit(main())
  File "/tmp/h/venv/lib/python3.6/site-packages/pip_faster.py", line 465, in main
    with pipfaster_packagefinder():
  File "/tmp/h/venv/lib/python3.6/site-packages/pip_faster.py", line 448, in pipfaster_packagefinder
    from pip._internal import basecommand
ImportError: cannot import name 'basecommand'

$ pip install 'pip<18.1'
Collecting pip<18.1
  Using cached https://files.pythonhosted.org/packages/5f/25/e52d3f31441505a5f3af41213346e5b6c221c9e086a166f3703d2ddaf940/pip-18.0-py2.py3-none-any.whl
Installing collected packages: pip
  Found existing installation: pip 18.1
    Uninstalling pip-18.1:
      Successfully uninstalled pip-18.1
Successfully installed pip-18.0

$ pip-faster install astpretty
Collecting astpretty
  slow: full search for unpinned requirement astpretty
  Downloading https://files.pythonhosted.org/packages/e3/61/16a1e2e2bf6270513d90695ad0d442a3521ab790562901288ef272fdc91a/astpretty-1.4.0-py2.py3-none-any.whl
Installing collected packages: astpretty
Successfully installed astpretty-1.4.0
You are using pip version 18.0, however version 18.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

[chriskuehl]

Just released 3.1.1 which should fix this?

[asottile]

Lucky for us pip had a good habbit on not breaking thinks

heh, the exact opposite seems to be true for venv-update 🙃

Can we do somethign to fix this in a way that would not require downgrading pip?

the way pip-faster works is by patching out parts of pip. It’s unfortunately fundamentally tied to the internals of pip.

The way out would be upstreaming the interesting bits:

• install --prune: uninstall things which are no longer depended on (there’s prior art in npm, shouldn’t be too hard to convince pip, though the hard part is finding the right place to inject this feature)
• “don’t consider the network if there are locally cached wheels and == is used” – we’ve tried to upstream this and were told no: https://github.com/pypa/pip/pull/2114 – it’s possible they’ll reconsider now that the internals are rearranged and less complicated. though I wouldn’t get my hopes up
• verify that pip-faster’s checking is compatible with pip check (and/or that there’s a pip install --check)