Setting PRICE, LATITUDE, LONGITUDE parameters the wrong way returns Server Code 200 w/ no data.

Overview

• Client ID: jyHeS_MVualewtI_Ab4wHg
• Issue type: bug
• Summary: Setting price parameter the wrong way returns server code 200 and no data.
• Platform: node-fetch (via React Native)

Description

I noticed that when I set the price parameter to 1,2,3,4 instead of 1, 2, 3, 4, the API will return an error with a server code of 200.

Endpoint

GraphQL Search API

Parameters or Sample Request

https://api.yelp.com/v3/graphql

POST body:

{
	search(term: "Restaurants", latitude: 40.747479, longitude: -73.98722, open_now: true, price: "1,2,3,4", radius: 10000, limit: 35) {
		business {
			name
			is_closed
			url
			phone
			display_phone
			review_count
			rating
			price
			photos
			distance
			attributes
			categories {
				title
				alias
			}
			location {
				address1
				address2
				address3
				city
				state
				zip_code
				country
			}
			coordinates {
				latitude
				longitude
			}
			hours {
				is_open_now
				open {
					day
					start
					end
					is_overnight
				}
			}
			reviews {
				text
				rating
				user {
					image_url
					name
				}
				time_created
				url
			}
		}
	}
}

Response

Extra information

1. Setting the price parameter a different way should not throw this kind of error.
2. Throwing this kind of error should return a server code 500, not 200.
3. The errors are not parsable using JSON.stringify() (without replacing characters) because they’re not really JSON due to the string characters being ' instead of ".

[dan98765]

For 3:

the error message not being parseable as valid json

I can just make it valid JSON with the quotes escaped… but on further thought I’m now leaning towards just changing the outputs to be more string-like.

Instead of:

{
	"errors": [
		{
			"message": "{'error': {'code': 'LOCATION_MISSING', 'description': 'You must specify either a location or a latitude and longitude to search.'}}",
			"locations": [
				{
					"line": 2,
					"column": 3
				}
			]
		}
	],
	"data": {...data goes here...}
}

The output would be more like:

{
	"errors": [
		{
			"message": "LOCATION_MISSING: You must specify either a location or a latitude and longitude to search.",
			"locations": [
				{
					"line": 2,
					"column": 3
				}
			]
		}
	],
	"data": {...data goes here...}
}

This feels a bit more in-line with other graphql implementations out there. We’d have the error string format be “CODE: DESCRIPTION”.

[dan98765]

latitude=0.0 causes server error

This fix is now live also; I checked that:

{
  search(term: "Restaurants", latitude: 0, longitude: 180, radius: 10000, limit: 35) {..OMITTED..}
}

no longer errors out.