Revamping Components - Typescript Types
See original GitHub issueI’m going to work on expanding the type definitions that were part of #86, in order to improve usability in a Typescript context. Specifically, the goal is to type all of blessed this will probably take a while, but bare with me 🙂
I have a few questions on naming and conventions moving forward.
-
The Components created by react-blessed are intrinsic types of React and therefore don’t require an import, is there a reason to use this approach following other component libraries and requiring imports?
-
Components have lowercase names? I don’t believe the issue that #86 solved is still a problem, right? So we could feasibly remove the prefix of
blessed-
and capitalize them following React conventions?
Would greatly appreciate feedback and reviews in the future to improve the state of the project, assuming that these changes are wanted if they’re not please say so ❤️
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:6 (1 by maintainers)
Top GitHub Comments
new definitions for react-blessed were published yesterday. they use module augmentation on react and jsx to replace html intrinsic elements with react-blessed elements (with and without the
blessed-
prefix). I’m not sure they’re 100% complete (I didn’t write defs forescape
andprogram
, for example) but they cover the example code and work for a small project I used them in.Thanks @NickHackman for the reply.
I’ve actually switched to a different framework — https://github.com/vadimdemedes/ink It’s actively developed and looks more up to date (along with types).
As for blessed, it doesn’t seem to be maintained as you know. That doesn’t necessary signals a problem — maybe it’s already ideal and there’s no bugs! eh? — but that’s unfortunately not the case and their issue queue has ~200 unresolved tickets.