Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Question about error handling

See original GitHub issue

👋 , I have a quick question about error handling.

It seems like this library assumes that a data object is always returned in the json payload and does not handle the use case where there is a top level errors object per JSON API spec https://jsonapi.org/format/#document-top-level. Is this correct (maybe i’m missing something)? If so, is there a way you are currently handling error formatting in the json payload?

Thanks in advance!

Issue Analytics

State:
Created 5 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

yury-dymovcommented, Feb 7, 2019

@iansolano currently I don’t see any reasons why not to add support for this, so feel free to file a PR and I will be more than happy to review it

1reaction

yury-dymovcommented, Feb 7, 2019

Hey @iansolano, you are correct, library doesn’t handle errors. I suppose that if your payload returned error, you wouldn’t store the data in regular redux data reducer (and therefore normalize it) but rather dispatch some kind of error action instead.

Feel free to share if you have something on your mind.