question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Inline code block outline is too dark on light background

See original GitHub issue

What is the problem?

If “Syntax: Decorations” are enabled, and you pick a light theme, then inline code blocks have too dark of an outline around them.

How can I reproduce it?

  • Set "markdown.extension.syntax.decorations": true.
  • Set "workbench.colorTheme": "Default Light+" (switch to light editor color theme).

Screenshot:

vscode-markdown code blocks

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:10 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
Lemminghcommented, Nov 10, 2020

If nothing is wrong, I will push to master at 2020-11-15T12:00Z.

0reactions
yzhang-ghcommented, Nov 10, 2020

Nice work!

Just to add a few screenshots

GitHub Light image

GitHub Dark image

Actually, I don’t have a strong preference on the colors. So looks good to me.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Code Blocks Difficult to See (for me) - TidBITS Talk
I think the background color for code blocks is subtle by design, ... The inline code on that Dark theme background is --primary-very-high: ......
Read more >
Background color of inline code should match background ...
A code block's background color. does not need to match inline code's background color as they serve different purposes.
Read more >
prefers-color-scheme - CSS: Cascading Style Sheets | MDN
The prefers-color-scheme CSS media feature is used to detect if a user has requested light or dark color themes.
Read more >
Theme Color | Visual Studio Code Extension API
Colors inside a text document, such as the welcome page. textBlockQuote.background : Background color for block quotes in text. textBlockQuote.border : Border ...
Read more >
What is Dark Mode for Email and Does it Affect Rendering?
Many developers are already quite familiar with dark mode since it's a popular way to view code. Dark Mode is also ideal for...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found