Post body empty when using Spring MVC @RequestParam to handle a application/x-www-form-urlencoded form POST

When logbook-spring-boot-starter is enabled @RequestParam are null

Description

For a valid form POST the following code results in a 400 error. The Spring controller doesn’t see the POST body and the fields are null. Since the @RequestParam fields are required it returns a 400 error.

   @PostMapping("/form")
    public ModelAndView handlePost(@RequestParam String field1, @RequestParam String field2) {

Expected Behavior

The POST body should be processed by Spring MVC whether or not logbook is enabled.

Actual Behavior

Spring MVC can’t process the POST.

Possible Fix

Saw a similar bug about missing a flush call. We use logbook on another project that has a JSON POST body and it works fine. Seems to just be isolated to application/x-www-form-urlencoded

Steps to Reproduce

See https://github.com/dillon-sellars/logbook-bug

Context

Just wanted to add logging to app, broke form posts instead.

Your Environment

• Version used: 2.3.0
• Link to your project: https://github.com/dillon-sellars/logbook-bug

[dillon-sellars]

Ah I see, but your default configuration should not break the way servlets work. I would consider making the default parameter or off. I would go so far as to say the body options shouldn’t even exist - does an option where getParameter doesn’t work have a valid use?

[no-response[bot]]

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don’t have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.