2 MiB JPEG in state -> tab crashes

Type that gets placed inside an object inside the state:

/**
 * Result type of the rendering.
 */
export type RenderResult =
  { imageWidth: number,
    imageHeight: number,
    /**
     * The normalised image (orientation is now = 1, the default)
     */
    image: ImageData,
    thumbWidth: number,
    thumbHeight: number,
    /**
     * The thumbnail of the image.
     */
    thumb: ImageData,
    /**
     * Optional image data.
     */
    exif?: Object
  }

Data is extracted as such:

const image = scratch.getContext("2d").getImageData(0, 0, scratch.width, scratch.height);

This happens even if redux is not the active tab in DevTools, so this bug precludes e.g. having the console open.

Chromium latest via homebrew.

[haf]

For posterity and googlers like myself in the future:

const ppValue = (value: any): any => {
  if (Array.isArray(value)) {
    return value.map(ppValue);
  } else if (value instanceof ImageData) {
    return `<<ImageData(w=${value.width}, h=${value.height}, #bytes=${value.data.byteLength}})>>`;
  } else if (value instanceof File) {
    return '<<File>>';
  } else if (value instanceof FileList) {
    return '<<FileList>>';
  } else if (typeof value === 'object') {
    return ppMap(value); // eslint-disable-line no-use-before-define
  } else {
    // primitives
    return value;
  }
}

const ppMap = (map: Object) => {
  if (map == null) {
    return map;
  }
  const tmp = {};
  Object.keys(map).filter(k => map.hasOwnProperty(k)).forEach(k => {
    tmp[k] = ppValue(map[k]);
  });
  return tmp;
}

// ... stateSanitizer: ppMap

[zalmoxisus]

That color shows that there’s an inconsistency between the state on client side and on the extension side (action index is different). We’d add an option to run it from client side in 3.0, so it won’t be necessary to sanitize.