question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Blacklisted actions still contribute to the actions history

See original GitHub issue

I would like to hide some type of actions in Redux DevTools history. In the documentation I’ve found an information about actionsBlacklist option, which I am passing to

window.__REDUX_DEVTOOLS_EXTENSION__(...)

This has some effect, i.e. I no longer see the blacklisted actions, but behind the scenes they still contribute to the history length, so instead of seeing the history of default length (50) I can only see a couple of most recent actions that has not yet been pushed back but the blacklisted ones.

Looks like increasing the history length, which as far as I understand is controlled by the maxAge option, helps a bit but it feels like a workaround rather than a real solution.

I am wondering if there’s a better way to fix this behavior which I described above and if it’s even intended or just a BUG?

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Reactions:6
  • Comments:8 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
zalmoxisuscommented, Nov 27, 2018

It’s implemented in 2.16, which will land in a day on Chrome Store. It works only for balcklisted/whitelisted actions. For predicate it would require a major refactoring as the state is computed after maxAge is called.

1reaction
zalmoxisuscommented, Nov 17, 2018

I introduced the concept of dynamic maxAge in https://github.com/zalmoxisus/redux-devtools-instrument/pull/22, so on the extension part we can readjust it every time a current action was blacklisted. Should have this in next version, no changes needed from client side. However, it will be also possible to readjust it by passing a function for maxAge, which will get current action as argument (so you can change depending on the type or payload). But for most of cases it will work out of box providing a number, which will be automatically changed depending on whitelisted actions.

Read more comments on GitHub >

github_iconTop Results From Across the Web

s3-bucket-blacklisted-actions-prohibited - AWS Config
Checks that the S3 bucket policy does not allow blacklisted bucket-level and object-level actions for principals from other AWS Accounts.
Read more >
Hollywood blacklist | History, Effect on Society, & Facts
The blacklist was implemented by the Hollywood studios to promote their patriotic credentials in the face of public attacks and served to shield...
Read more >
Config Rules: s3-blacklisted-actions-prohibited
A config rule that checks that the Amazon Simple Storage Service bucket policy does not allow blacklisted bucket-level and object-level actions on resources ......
Read more >
Financial Action Task Force blacklist - Wikipedia
The blacklist has been issued by the FATF since 2000, and lists countries which FATF judges to be non-cooperative in the global fight...
Read more >
House Un-American Activities Committee | The First ...
Among them was noted film director Elia Kazan, who named numerous people who he believed were communist sympathizers, and they too were blacklisted....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found