question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

west init should recursively handle submodules for the manifest repo

See original GitHub issue

To make the workflow west init ... west update fully working for manifest repositories with submodules, west init command should recursively get git submodules.

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:2
  • Comments:25 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
mbolivar-nordiccommented, Apr 20, 2021

My point is that I don’t like the name --git-opt because it is ambiguous. In the west init case, --clone-opt is very specific. I would say we could add --diff-opt to west diff and --status-opt to west status for similar reasons. These are not likely to be difficult to remember even though they are different, because the name of the option is right there in the command name.

For west update, a --git-opt is “just wrong” in my opinion. The west update command in particular runs git a lot of times for different purposes and a generic --git-opt option there is particularly confusing.

1reaction
marc-hbcommented, Apr 14, 2021

That west init checks out the manifest repo at all made me have different expectations then what it is designed for I think.

That’s a very fair point and in fact in 4th comment above I wrote:

So it would affect west init only when used without -l, correct? Seems fine as long as it’s possible and easy to manually git clone the manifest repo non-recursively and take it from there.

However this all has to be balanced against implementation complexity, other preferences and priorities, “future-proofness” and last but not least limited manpower to deal with it all. For now it seems the person writing 98% of the west code makes the technical decisions (after attentive consultation) and for the coherence and success of the project I hope it stays that way 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

West Manifests - Zephyr Project Documentation
The path west init should clone the manifest repository into, ... west update will recursively update the project's Git submodules whenever ...
Read more >
Can repo recurse submodules? - Stack Overflow
The answer is YES. Two options: in your manifest, you can specify the attribute sync-s="true". for example <default sync-s="true"/> to apply ...
Read more >
Git - Submodules - Git SCM
Submodules allow you to keep a Git repository as a subdirectory of another Git ... You must run two commands: git submodule init...
Read more >
Git Submodules vs. Google's Repo Tool | Edureka Blog
This blog post weighs the pros and cons of using Git Submodules vs. Google's Repo Tool to manage multi-repository integrations in git.
Read more >
Nested submodules and transitioning to repo - Google Groups
I'm already set sync-s "true" inside the manifest, and tried to repo sync with ... ~/bin/repo forall <repoName> -c "git submodule update --init...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found