Symbolic link without actual file link caused FileNotFoundException

At https://github.com/zeroturnaround/zt-zip/blob/master/src/main/java/org/zeroturnaround/zip/ZipUtil.java#L1736 - String[] filenames = dir.list(); doesn’t guarantee return the list of files which are exists in the directory. If there is a symbolic link which link to not exists file, dir.list will return the file name but access the file will throw FileNotFoundException.

Steps to reproduce (must at Linux environment)

1. touch file
2. ln -s file link
3. run ZipUtil::pack to pack the directory contains file create above
4. rm file
5. observe the exception. FileNotFoundException

The solution should always ensure the file is exists.

for (int i = 0; i < filenames.length; i++) { String filename = filenames[i]; File file = new File(dir, filename) if(!file.exists()) { continue; }

[toomasr]

I think I’ll throw away the current copying, start relying on Java 7 and bump the requirements. Anybody still on Java 6 will have to do with the current functionality.

[goxr3plus]

Yes let’s throw Java 6 and move on Java 7 . Very few companies are still using Java 6 . @toomasr