iOS: stringByRemovingPercentEncoding breaks

In RNSound.m, my AVAudioPlayer errors out because of this line of code: fileNameUrl = [NSURL URLWithString: [fileName stringByRemovingPercentEncoding]]; if I change it to fileNameUrl = [NSURL URLWithString: fileName]; it works fine.

However, I’m uncomfortable changing this code. Is there a reason for using stringByRemovingPercentEncoding ? I’m try to play audio from my aws s3 bucket.

[alfonsodev]

I agree because this string replacement the module can not play from Firebase Storage Services which uses %2F in file names.

[anthonyjoeseph]

Why is this library written to explicitly remove percent encoding on network uris, when NSData seems to require percent encoding?

Local uris also have their percent encoding removed. Though that works, it seems unnecessary, since fileURLWithPath adds percent encoding back on again.

And why is this only in the code for ios, not android? The code for Android reformats local uris (in sound.js) but not network uris.

A side note - [NSData dataWithContentsOfURL:] is deprecated because it’s synchronous, and should be replaced with the asynchronous [[[NSURLSession sharedSession] dataTaskWithURL:_ completionHandler:_] resume] .