Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update install instructions in README

See original GitHub issue

Following the install instructions verbatim won’t work. react-native link requires the library to be in your package.json, and so it does nothing unless react-native-push-notification is saved to the package.json. To make things really clear, the instructions should be changed to:

npm install react-native-push-notification --save
react-native link

Issue Analytics

State:
Created 7 years ago
Comments:5

Top GitHub Comments

1reaction

sebocommented, Mar 4, 2017

@mcrowe there is actually already a pull request https://github.com/zo0r/react-native-push-notification/pull/326 . I actually don’t know why they wouldnt merge it…

0reactions

mcrowecommented, Mar 27, 2017

Yup. Looks like this was fixed in commit e17d8a1f065dbe5f2f3ab864f0cf2e56bd778bc6, which is merged into master. Closing.

Top Results From Across the Web

Keep Your README Install Instructions Up To Date - DockYard

A simple unit test ensures compatibility between your Elixir app's current version and the version constraint in your README's installation ...

Update Installation instructions in readme · Issue #24 - GitHub

Update the "Installation" section of readme.md: describe how to install the component using Add-ons Marketplace.

README.md template | Documenting your project - Drupal

Information about content and formatting of project README files. ... Installation (required, unless a separate INSTALL.md is provided) ...

Writing a README

Every GitHub repository should include a README.md file that provides any ... Complete setup/installation instructions: At this point, your setup and ...

Update the Readme | Talaria Software

In this article, we are talking about updating the readme file. When. Every time there is some new piece of information that every...