question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add support for email address changes with SAML when `attr_permanent_user_id` is not `email`.

See original GitHub issue

Zulip’s existing authentication model is that a user’s email address is a unique ID; this simplifies the model for supporting several different authentication backends. However, where this gets messy is some SAML providers, like Shibboleth, are designed to support users changing their email address while having some other key (E.g. a unique user ID) that’s unique.

What we’d like to do is store the attr_user_permanent_id field, and then during a SAML authentication, look up users by that unique ID, and if we find one, and the email address is different, change the email address to match the SAML value.

(May need to be an optional server-letting setting, but we can worry about that once we have this prototyped)

We have existing work on the analog of this issue for LDAP here: https://github.com/zulip/zulip/pull/16208. We’ll likely want to reuse most of the logic/strategy, if we can.

See this chat.zulip.org discussion for background.

I’ve tagged this as difficult because it requires some understanding of SAML.

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:11 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
seiwailaicommented, Apr 9, 2021

@ro-i Yup, I am working on this issue. Nevertheless, it is fine for me if you make a pull request to this issue

0reactions
ro-icommented, Jun 5, 2021

In case someone wonders where the discussion about these changes is going on: https://chat.zulip.org/#narrow/stream/3-backend/topic/ext_auth_id.20create_user

Read more comments on GitHub >

github_iconTop Results From Across the Web

SAML login fails for a user whose email was changed
Cause. Email address change tracking requires that the identity provider send us a unique, unchanging id for the user. This id goes in...
Read more >
Customize app SAML token claims - Microsoft Entra
Learn how to customize the claims issued by Microsoft identity platform in the SAML token for enterprise applications.
Read more >
Set up SSO for your organization - Google Support
Sign in to your Google Admin console. · In the Admin console, go to Menu · Under Third-party SSO profiles, click Add SAML...
Read more >
Best Practices to Change Email Addresses or Domains
This applies to the ADFS, SAML, and Google G-Suite identity providers. If you do not use a maintenance window, then changes to email...
Read more >
SAML Single Sign-on - monday.com Support
To enable SAML using Azure AD, please click here. ... Therefore, if a user changes their email address, they will not be able...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found