question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Create common administrative "Edit modal" widget similar to confirm_dialog

See original GitHub issue

We have several modals with very similar implementations, that would likely benefit from sharing a common framework:

  • The “Edit bots” modal
  • The “Edit user” modal
  • The “Edit linkifier” modal, static/templates/settings/admin_linkifier_edit_form.hbs
  • The “custom profile fields” edit widget is inline probably should be converted into a modal.

We should create a edit_fields_modal widget that can share much of the copy/pasted code (especially HTML template code) for these widgets.

Tagging as difficult because this requires careful refactoring, grepping, commit structure, and manual testing to do this productively without requiring a lot of reviewer work to manually test.

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:11 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
ritikchauhan-01commented, Jun 8, 2021
1reaction
ritikchauhan-01commented, May 22, 2021
Read more comments on GitHub >

github_iconTop Results From Across the Web

Confirm Dialog | Components | Vaadin Docs
Confirm Dialog is a modal Dialog used to confirm user actions. ... You can edit their labels and change their theme variants.
Read more >
How can I display a modal dialog in Redux that performs ...
Let's say I want to remove something, then I'll dispatch an action like deleteSomething(id) so some reducer will catch that event and will...
Read more >
Confirm Dialog In Angular Using Bootstrap Modal - C# Corner
This article shows how to create a custom component for Confirm Dialog in Angular using modal popup of bootstrap.
Read more >
Formatting confirm dialog pop-up boxes - ServiceNow
Our team has onSubmit client scripts that bring up a confirm pop-up dialog box: var action = g_form.
Read more >
Modal | Block Editor Handbook
Modals give users information and choices related to a task they're trying to accomplish. They can contain critical information, require…
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found