custom emoji overrides default emojis in emoji picker

Note by @timabbott: We support overriding default emoji with a custom image, but also want to make sure users know this is happening when they do it.

I think we probably do want to allow overriding the image for a standard emoji if one wants to. Perhaps we want to (A) warn that when one is doing this in the UI and require confirmation and (B) perhaps require that the uploading user be an organization administrator to do so? (From https://github.com/zulip/zulip/issues/16913#issuecomment-747817924).

• https://github.com/zulip/zulip/pull/16937 addresses (A).

---

Original report below

Server Version: 3.3

Expected Behavior

When users upload custom emojis and choose names for them, if the name was already taken by a default emoji, then it should not save

Actual Behavior

One user uploaded a custom emoji and named it cry, which happens to also be a default emoji code :cry: 😢 https://emojipedia.org/crying-face/

Then in the emoji picker the default one is suppressed and not shown

message value: :cry: 😢 Actual rendered msg:

Solution

Would it be possible to block custom emojis using default emoji names? Would that be too expensive to check?

[timabbott]

There’s a legitimate use case for this with an organization that wants to use a specific image. E.g. a company named “dragon” might want to use their logo for :dragon: rather than the standard image.

I think we probably do want to allow overriding the image for a standard emoji if one wants to. Perhaps we want to (A) warn that when one is doing this in the UI and require confirmation and (B) require that the uploading user be an organization administrator to do so?

[timabbott]

This was closed by #16913 via adding the confirmation dialog. I’m not sure there’s anything else we definitely want to do here, but if so, we should open as a new issue. (E.g. if we think overriding default emoji should be limited to moderators and above as separate from the existing setting controlling who can upload custom emoji, we could try to design something there; I’m not sure it’s worth doing, though).