[bug] Cannot do OTA: "Unable to extract firmware from file"

Version

Build/Run method

• Docker
• PKG
• Manually built (git clone - npm install - npm run build )

zwavejs2mqtt version: 1.1.0 zwavejs version: 6.1.3

Describe the bug

Trying to upgrade firmware on a IDlock 150, zwavejs2mqtt doesnt seem to understand the format. The 1.6 firmware doesnt have a fileending, but the previous firmwares had .hex. Tried renaming the file as well;

2021-02-09 08:23:01.270 INFO ZWAVE: Calling api beginFirmwareUpdate with args: [
  62,
  'IDLock_OTA_1_6.hex',
  <Buffer 3a 30 32 30 30 30 30 30 34 30 30 30 30 46 41 0d 0a 3a 31 30 31 38 30 30 30 30 30 32 32 37 33 33 31 41 37 30 31 41 37 35 32 32 37 46 42 38 45 46 39 30 ... 233342 more bytes>,
  0,
  [length]: 4
]
2021-02-09 08:23:01.499 INFO ZWAVE: Unable to extract firmware from file: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received undefined beginFirmwareUpdate {
  success: false,
  message: 'Unable to extract firmware from file: The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received undefined'
}

To Reproduce

Steps to reproduce the behavior:

1. Go to ‘Node X’
2. Click on ‘Node actions’
3. Scroll down to ‘Begin firmware update’
4. Choose firmware from https://idlock.no/idlock_ota_v_1_6/
5. See error

Expected behavior

Firmware to extract correclty and start OTA process

[AlCalzone]

Okay I found it. The file is hex-encoded and the encoding seems to differ from the files I’ve seen so far.

[AlCalzone]

Okay, so the difference is that your HEX file contains “holes” - regions of data that have to be filled with 0xff. We used to assume that they only contain a single block.