MeterCC.ts creates value labels that cannot be distinguished
See original GitHub issueDescribe the bug
When selecting a meter value in zwavejs2mqtt (e.g. from a Shenzehen Neo NAS-WR01ZE Wall Plug) the selection box shows identical labels for all meter values which cannot be distinguished for which unit it is (kWh, W, V, A).
This is a screenshot from the value selection:
This is a screenshot that shows that multiple values have identical labels and would not be able to distinguish, if the UI would not output the unit as well:
Maybe the value labels could be improved a bit as well (shorter with more meaningful names).
Device information
Which device(s) is/are affected (make/model)? Shenzehen Neo NAS-WR01ZE Wall Plug What are the node IDs? Node 080 (see logs). Device IDs: 600-4135-512 (0x0258-0x1027-0x0200)
The bug affects not only this device but all devices using the meter CC.
Installation information
How did you install node-zwave-js
? Zwavejs2mqtt (dev) docker image
To Reproduce Steps to reproduce the behavior:
- Go to zwavejs2mqtt settings
- Click on ‘New Value’ on the bottom left
- Select a device supporting the meter CC
- Open the value select - it shows multiple identically named values, unable to distinguish
Logfile: zwavejs-log.zip
Issue Analytics
- State:
- Created 3 years ago
- Comments:5 (5 by maintainers)
Top GitHub Comments
I see.
What about the following suggestion for a generic label generation:
This would generate the following labels:
Not exactly much shorter, but unique. I’ll collect a few more votes.