question-mark

Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improvement idea: add `choice` prop to features giving a subclass

See original GitHub issue

Issue Description

Just like the title says. There are feautres, where you choose something form an array of opitons, be it expertise, eldritch invocation or fighting style. Why not treat subclasses the same way?

Proposed structure:

{
    "index": "otherworldly-patron",
    "class": {
        "index": "warlock",
        "name": "Warlock",
        "url": "/api/classes/warlock"
    },
    "name": "Otherworldly Patron",
    "level": 1,
    "desc": [
        "At 1st level [yada yada]."
    ],
   "choice: {
        "choose": 1,
        "type": subclass
        from: "api/classes/warlock/subclasses"
    }
    "url": "/api/features/otherworldly-patron"
}

I know there is only one subclass in the SRD, but as y’all mentioned before, if something comes from a feature, you like to keep it within that feature, so why not add information about subclass choices to the feature giving you a subclass?

Issue Analytics

  • State:open
  • Created 3 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
Freedziocommented, Sep 14, 2020

When you put it that way, ye, my propositon would stir some disinformation. feature_specific approach is cleaner. It indicates that this feature has some logic/complexity behind it and allows the api cosnumer to deal with it the way it needs to. Just like class_specific data

0reactions
fergcbcommented, Sep 14, 2020

Yeah, this is exactly what I meant when I was talking about how the feature_specific property would help keep things organised as we expand on all the features in this way.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Subclass or Extend classes in Swift | by Steven Curtis - Medium
Class: An object that defines properties and methods in common ... Subclasses are also nice in that you can give your code a...
Read more >
Help adding options to a Subclass Feature - D&D Beyond
I am having trouble getting the options to show in the drop down in the character builder. I have created two options that...
Read more >
Overriding fields or properties in subclasses - Stack Overflow
Option 1: Use an abstract Property and override it on the inherited classes. This benefits from being enforced (you have to override it)...
Read more >
Java Inheritance Tutorial: explained with examples
Inheritance is the process of building a new class based on the features of another existing class. It is used heavily in Java,...
Read more >
c# - How can I add properties to subclasses and access them ...
Although I'm starting to think I should just expand Product into a class, and then give it a Term property. But we run...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found