question-mark

Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Monster Data is missing Armor Type

See original GitHub issue

Issue Description

The SRD includes armor types for monsters, such as:

Aboleth: 17 (natural armor)

Thug: 11 (leather armor)

The armor type is not provided along with the monster data. I propose we add it as an armor_type field.

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:3
  • Comments:32 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
bagelbitscommented, Dec 16, 2022

@Redmega @fergcb #518 Is all done and has all of the data added in. This will be a breaking change. I’ll need to do the API changes as well but that can be another day.

2reactions
JaysonMendozacommented, Dec 17, 2020

Heya, Sorry for poping in since I’m fairly new here. In reading this I would suggest we consider how the API might be used in a program, so with that being said I am with txtsd in thinking that notes should be limited to “human readable” text that is not used to provide important data.

I like the idea of the armor key holding an array of document values that describte the armor attributes. I also recognize the need to indicate that some have an associated condition or state, especially with shape changes or fighting stances that are common to many creature types.

So I would propose that we add a new key to the main creature api document that might look something like

"states" : ["humanoid","bear form","hybrid form"]

I also considered implying a default state, but I think we can just leave it at state index 0 since the DM would choose this.

This state key would represent an enumeration type declaration. I would propose that ANY subdocument may use the

"required_state"

key and include an array of states that enable the use of this document.

"armor": [
    {
      "armor_class": 10,
      "armor_type" : "natural",
      "required_state" : [ "humaniod" ]
    },
    {
      "armor_class": 11,
      "armor_type": "natural",
      "required_state" : [ "bear form","hybrid form" ]
    }
  ]

This could also work to simplify the “actions” key too

"actions": [
		{
			"name": "Multiattack",
			"desc": "In bear form, the werebear makes two claw attacks. In humanoid form, it makes two greataxe attacks. In hybrid form, it can attack like a bear or a humanoid.",
			"options": {
				"choose": 1,
				"from": [
					[
						{
							"name": "Claw",
							"required_state" : [ "bear form","hybrid form" ],
							"count": 2,
							"type": "melee"
						}
					],
					[
						{
							"name": "Greataxe",
							"required_state" : [ "bear form","hybrid form" ],
							"count": 2,
							"type": "melee"
						}
					],
					[
						{
							"name": "Greataxe",
							"required_state" : [ "hybrid form" ],
							"count": 1,
							"type": "melee"
						},
						{
							"name": "Claw",
							"required_state" : [ "hybrid form" ],
							"count": 1,
							"type": "melee"
						}
					]
				]
			},
			"damage": []
		}

This design choice would also be useful for things like fighting styles, and can help a programmer handle monsters with various states by detecting if the state array length. It can be implicit that if the states key has no value, then we don’t need to check for conditions.

Just a thought, and thanks for hearing me out!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Category:Missing Armor Data | Monster Hunter Wiki - Fandom
Missing Armor Data. Category Page ... Alloy Armor (Blademaster) (MH4). Anat Armor (Blademaster) (MHX) ... Brachydium Armor (Blademaster) (MH4U).
Read more >
Armor vareity in rise.... :: MONSTER HUNTER RISE General ...
I was wondering , why we dont have the same armor variety like in MH:world? If i remember world had atleast type A...
Read more >
My registered armor sets keep getting some of the parts ...
Pretty sure armor sets are registered to your SD card so if you switched to a different 3DS or a different SD card...
Read more >
Where To Get Layered Armor In Monster Hunter Stories 2
If you're wondering what Layered Armor is or where to get it in Monster Hunter Stories 2: Wings of Ruin, here's everything you...
Read more >
How to Unlock Layered Armor - Monster Hunter Rise Layered ...
The game plays perfectly. It's just missing some key elements that appear tied to future Title Updates that start about a month after...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found