Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Breaking change in function behavior getItemById ( Dataview )

See original GitHub issue

Issue Description

In the version 2.4.32

const Item = this.dataView.getItemById(id);

with id = ‘99’ or 99 it works.

In version 2.4.33 with id = ‘99’ getItemById does not work anymore

// work
function getItemById(id) {
      return items[idxById[id]];
    }
//  does not work

function getItemById(id) {
return items[idxById.get(id)];
 }

Issue Analytics

State:
Created 2 years ago
Comments:5

Top GitHub Comments

1reaction

bzhjackcommented, Feb 10, 2021

ok i will adapt my code 😃 thanks

0reactions

ghiscodingcommented, Feb 10, 2021

BTW, since you’ve talked about Angular… you can take a look at my lib Angular-Slickgrid, it’s a wrapper on top of this SlickGrid fork which works out of the box for Angular with a lot of extra goodies.

Thanks for your issue feedback, I wasn’t aware of any impact, so it’s a “good to know” fact about this new strict equality. Have a nice day

Top Results From Across the Web

SlickGrid/example4-model.html at master - GitHub

<li>a filtered Model (DataView) as a data source instead of a simple array</li> ... and <b>real-time</b> grid updating in response to data changes.<br/>....

Tooltip Implementation - Documentation - Webix

Webix Documentation: Managing Data in a Component of Guides. This page contains Tooltip Implementation documentation to help in learning the library.

Breaking Changes & Dataview API Upgrades

Breaking Changes & Dataview API Upgrades. Multiple windows is now a core feature, allowing for improved dual monitor use of Obsidian.

Closures - JavaScript - MDN Web Docs

A closure is the combination of a function bundled together (enclosed) with references to its surrounding state (the lexical environment).

Should behavioural changes be considered breaking ...

Changing the functional behaviour of a function (like my example in the post) is a breaking change. Fixing a bug where a null...