Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Potential wrong GetSelectionLength method in ByteProvider.cs ?

See original GitHub issue

In ByteProvider.cs / GetSelectionLength() method (line #692) the test for no selection seems incorrect.

It is: if (selectionStop == -1 || selectionStop == -1) …

Shouldn’t it be ? “if (selectionStart == -1 || selectionStop == -1) …”

Issue Analytics

State:
Created 4 years ago
Comments:16 (9 by maintainers)

Top GitHub Comments

1reaction

chosteletcommented, Apr 13, 2019

Super !

Je continue d’explorer ta réalisation qui, je dois le dire, est rare.

–

Christian HOSTELET - Grenoble

De : Derek Tremblay notifications@github.com Envoyé : samedi 13 avril 2019 13:39 À : abbaye/WpfHexEditorControl WpfHexEditorControl@noreply.github.com Cc : Christian Hostelet christian.hostelet@free.fr; Author author@noreply.github.com Objet : Re: [abbaye/WpfHexEditorControl] Potential wrong GetSelectionLength method in ByteProvider.cs ? (#41)

Corrigé!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/abbaye/WpfHexEditorControl/issues/41#issuecomment-482801747 , or mute the thread https://github.com/notifications/unsubscribe-auth/AHS31rmi0dWncgmjARPOLQYiiYJ024QHks5vgcHvgaJpZM4ccSFF .

0reactions

abbayecommented, Apr 13, 2019

Je t’ai ajouté dans ma liste de follow 😃

Top Results From Across the Web

window.getSelection().getRange(0) does not work when ...

It works fine in a text without any <mark> and <abbr> . But when there are such tags in a sentence, it seems...

Window: getSelection() method - Web APIs | MDN

getSelection () method returns a Selection object representing the range of text selected by the user or the current position of the caret....

CGridView | API Documentation for Yii 1.1

CGridView displays a list of data items in terms of a table. Each row of the table represents the data of a single...

Untitled

Cortisol and estrogen relationship, Car accident albemarle county, Computer science illuminated w navigate 2 adv access edition 6th, #3 feet high and rising ......

https://raw.githubusercontent.com/microsoft/vss-we...

If false (the default) the extension is considered ready as soon as init is ... Gets the content length (in bytes) of all...