FindFirst/Last/Next
See original GitHub issueHi abbaye,
Thank you for your great work, I am leveraging your library in a project that allows users to navigate huge binary file: not only works nice, but it is also intuitive and well written.
Nevertheless I have a few problems with the Find
function family of the HexEditor
control: when a FindFirst/Next/Last
function is launched it won’t terminate until all of the matchings are found instead of returning immediately. I investigated the code and this behaviour is dictated by the ByteProvider.FindIndexOf
function here which keeps searching for all occurrences by design (causing a series of problems for big files a/o many matches).
May I help you with this improvement?
Expected Behavior
FindFirst/Last/Next
should return immediately after the given bytearray has been found.
Actual Behavior
FindFirst/Last/Next
returns after the whole file is searched for all matches
Steps to Reproduce the Problem
- Invoke the aforementioned function anytime anywhere.
Issue Analytics
- State:
- Created 4 years ago
- Comments:10 (7 by maintainers)
I will let you know in a while because at work I am stuck with 2017. I’ll build it at home on my laptop 😃
Hi Derek,
I’ve just managed to try it, but it seems not to work either using the dialog box or calling FindFirst directly (I see that you used an elgant yeld return statement but it doesn’t do the trick).