Support callback path based on IApplicationBuilder.Map paths
See original GitHub issueIs your feature request related to a problem? Please describe.
The current callback path does not work together with path matches defined in IApplicationBuilder.Map
. If adding the path match prefix from IApplicationBuilder.Map
to the callback path, the callback endpoint becomes nested.
What area is it related to BankIdAuthenticationHandler
Describe the solution you’d like
An option to add the path that I use in IApplicationBuilder.Map
to the callback path. This can then be used in an override of ShouldHandleRequestAsync
to handle the nested path.
Describe alternatives you’ve considered URL rewriting etc.
Additional context
I have an open stack overflow question on how to work around the issue but it does not seem possible without changing the BankIdAuthenticationHandler
.
I could spend the time implementing this if you think it it necessary and will make for a good addition.
Issue Analytics
- State:
- Created 4 years ago
- Reactions:4
- Comments:13 (13 by maintainers)
Top GitHub Comments
Had a look at your commit now, looks great from what I can see! You can make a PR so we can see that all tests are green etc. Also easier to comment if we were to find anything before merging 😃
Btw, GitHub has Draft PR:s nowdays. They are great for early feedback, but can’t be merged until the author (you in this case) says it’s ready to do so 😃
Very nice, I will dig right into it.
I am not sure why you think I need the
IHttpContextAccessor
though. There is anHttpContext
available in the base classRemoteAuthenticationHandler
that it receives in theInitializeAsync
method.It does not seems to affect the GrandId package:
Is there any documentation that you know of that should be updated together with this change?