Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

remove newData and oldData from componentchanged event in documentation version 0.7.0

See original GitHub issue

Hi,

I think the documentation needs to be updated here https://aframe.io/docs/0.7.0/core/entity.html#event-detail

As far as I can tell the newData and oldData properties are no longer present on the componentchanged event.

Issue Analytics

State:
Created 6 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

machenmusikcommented, Oct 25, 2017

@ngokevin I wonder if we should add a warning message into the static evt.detail object for oldName or newName so that if this change breaks code relying on newData or oldData, and you look at the value you are getting, it tells you what you should do instead in human-readable form?

0reactions

jafetmoralescommented, Oct 25, 2017

Something along these lines maybe: warn('event.detail.newData is deprecated. Use event.target.getAttribute(event.detail.name) instead.');