Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Support `<source>`s in `<video>`s (use `videoEl.src` in `a-assets` and `calculateVideoCacheHash`)

See original GitHub issue

Description:

The calculateVideoCacheHash helper function doesn’t take into account videos with <source>s (instead of a defined src attribute on the parent <video> element).

Example:

        <video id="video"
               autoplay loop crossorigin="anonymous">
             <source src="https://ucarecdn.com/fadab25d-0b3a-45f7-8ef5-85318e92a261/"></source>
        </video>

vs.

        <video id="video" src="https://ucarecdn.com/fadab25d-0b3a-45f7-8ef5-85318e92a261/"
               autoplay loop crossorigin="anonymous">
             <source ></source>
        </video>

/cc @machenmusik

A-Frame Version: 0.7.0/master
Platform / Device: All / Any
Relevant Code Snippet: https://github.com/aframevr/aframe/blob/27d984f2/src/systems/material.js#L250-L278

Issue Analytics

State:
Created 6 years ago
Comments:25 (25 by maintainers)

Top GitHub Comments

1reaction

machenmusikcommented, Oct 18, 2017

Yes, my point is that useful frameworks distinguish themselves over time, and to stipulate that you can’t use them makes the overall solution less useful. I think we are all hoping that any of the WebVR frameworks proves as useful as THREE has for WebGL, or as others have for video.

0reactions

machenmusikcommented, Oct 18, 2017

Let’s move from abstract to concrete discussion on #3176. Only slightly more than getAttribute / hasAttribute, have a look.

Top Results From Across the Web

The Video Embed element - HTML - MDN Web Docs - Mozilla

The HTML element embeds a media player which supports video ... This is optional; you may instead use the <source> element within the...

The <video> and <source> tags - web.dev

The <source> element lets you specify multiple formats as a fallback in case the user's browser doesn't support one of them. The example...

HTML video src Attribute

Definition and Usage. The src attribute specifies the location (URL) of the video file. The example above uses an Ogg file, and will...

Video element visual-only content has accessible ...

G159: Providing an alternative for time-based media for video-only content ... controls> <source src="/test-assets/rabbit-video/audio-description.mp3" ...

HTML5 video local source + web source

I actually solved this by simply installing a local webserver and pointing the first source to localhost, and the second to my website....