Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

FlowTyped Declarations

See original GitHub issue

In usage with Flow, I get errors like this:

I am wondering that, since the values passed into condition are negated to truthy or falsey, shouldn’t it accept any type?

Apologies if this question belongs elsewhere. If so, please do direct me.

Issue Analytics

State:
Created 6 years ago
Reactions:1
Comments:5 (1 by maintainers)

Top GitHub Comments

1reaction

JalilArfaouicommented, Apr 4, 2018

Hello @AlexGilleran

I agree it is a matter of opinion if we should or not have an explicit boolean cast in conditions.

Except that I think, like @colshacol, that we should have a consistent behavior between if (foo) and <If condition={foo}>.

So, since Flow does not raise an error on if statement with non-boolean value, I think this link should not either.

https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoVUCuA7AxgFwEs5swo44AKADwC4wBnfAJ0OwHMBKep1jsAN6owYQlDA1Og4SLDMApvkzNS1ANwyAvjIVKVYAEQATeVACGmGPkYs27Axu1A

0reactions

draperunnercommented, Jun 15, 2018

I agree @colshacol and @JalilArfaoui . Since it is so obvious that whatever passed into <If condition={}> will be treated as a boolean, like a normal if statement in JavaScript, I think it should be typed as any.

In my project we end up casting all statements with Boolean() like this: <If condition={Boolean(...)}>, which I think is just noisy.