Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

12-hour clock or 24-hour clock time in line charts?

See original GitHub issue

In the floating tooltips of line charts, I get time ranges like 0-0:05am and 23:55pm-0am. These timestamps append am/pm to a 24-hour clock, so they don’t follow the 12-hour clock rules.

Do you think it’s better to adhere to one of the standard time conventions (by removing the am/pm part, or minus 12 from the number of hours for >=13:00 and set 0am to 12am)?

Issue Analytics

State:
Created 5 years ago
Comments:13 (9 by maintainers)

Top GitHub Comments

1reaction

adrianmrozcommented, Jan 18, 2019

No, table labels and x-axis on line chart have additional logic to format time, so they have own methods: https://github.com/allegro/turnilo/blob/master/src/client/visualizations/table/table.tsx#L57 and https://github.com/allegro/turnilo/blob/master/src/client/components/line-chart-axis/line-chart-axis.tsx#L39 respectively. They both use d3.time to format and I think this function doesn’t respect timezone so it’s tied to #274. We need to think about what should be displayed and then use one formatter - d3.time.format or moment.format.

0reactions

l2dycommented, Jan 30, 2019

The bug is fixed, and we have a plan in #288 for unified time formatting. I’m closing this issue.