question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove deprecated `govuk-main-wrapper` mixins

See original GitHub issue

What

Remove a deprecated feature: govuk-main-wrapper and govuk-main-wrapper--l mixins. Instead, people should replace this mixin with more direct references to the spacing mixins

Why

The govuk-main-wrapper and govuk-main-wrapper--l mixins were marked as deprecated in v3.0.0

We’re not sure these are useful, so these will be removed in a future release, if you are using either of these please let us know.

Who needs to know about this

Developers, Tech Writer

Done when

  • govuk-main-wrapper mixin has been removed
  • govuk-main-wrapper--l mixin has been removed
  • Does any existing documentation refer to these mixins?
  • “Details of breaking change” section below completed to help with writing release notes

Details of breaking change

  • which users are affected: anyone using the govuk-main-wrapper or govuk-main-wrapper--l mixins in their Sass
  • the change that’s been made: we’ve removed the govuk-main-wrapper and govuk-main-wrapper--l Sass mixins
  • changes users will have to make: if they’re using these mixins, they need to remove them. They can replace them with direct calls to our spacing mixins
  • impact of users not making those changes: if they’re using these mixins and don’t remove them, their Sass will start erroring because it won’t be able to find the mixins anymore.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
vanitabarrettcommented, Sep 8, 2021

Thanks @EoinShaughnessy , good shout. I don’t think the spacing mixins guidance needs updating, but it looks like we do reference these mixins in https://design-system.service.gov.uk/styles/layout/#page-wrappers

0reactions
EoinShaughnessycommented, Oct 18, 2021

@vanitabarrett Ah great, thanks - good to know!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Warning: The `invisible()` mixin has been deprecated as of v4 ...
Warning: The `invisible()` mixin has been deprecated as of v4.3.0. It will be removed entirely in v5. Am getting this warning from specs:....
Read more >
Remove deprecated `mixins` · Issue #108 · dojo/compose · GitHub
Bug The base classes have been adopted through out the dependent modules, meaning the that the legacy mixins/* can be removed. Package Version:...
Read more >
Idsk-frontend-repository
mixins. govuk-main-wrapper. Deprecated! Replace this mixin with more direct references to the spacing mixins.
Read more >
Is it possible to deprecate a sass/scss mixin? - Stack Overflow
I do not simply want to remove the deprecated mixins as it will take some time to remove all the current uses, but...
Read more >
https://raw.githubusercontent.com/alphagov/govuk-f...
Remove deprecated `govuk-main-wrapper` and `govuk-main-wrapper--l` mixins We've removed the `govuk-main-wrapper` and `govuk-main-wrapper--l` mixins we ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found