Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
🌸 Cherry-pick request for #36719 into #36411, #36637
See original GitHub issueIssue (P0 Bug)
Pull Request(s)
Release Tracker(s)
Channels
Beta / Experimental, Stable
Formats
Stories
Justification
The bug introduced breaks severely the layouts on stories on major browsers (Chrome, Safari, etc) on mobile. Happens for stories made with multiple editors (confirmed for NWS, MakeStories).
Verification Steps
Check the second page of https://stories.nws.ai/1288496525/new-omnichannel-customer-experiences/ for the text to not overlap. On the PR I took screenshots of the page before reverting the code (the PR linked) and after
Summary
CSS viewport units don’t match JS calculated units, so some stories’ layouts broke on those browsers where vh != %.
Impact
Stories created with multiple tools (or manually) that rely on --story-page-vh or --story-page-vmax have the layouts broken due to those CSS vars changing values.
Action Items
No response
Notifications
/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
CP complete on stable
2110152252003and beta2110212130002. Will proceed to promote beta to stable tomorrow.No, good question, I am CPing the current stable
2110152252002as well as beta and this week’s beta candidate