Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

commonJsToGoogmoduleTransformer misses some `module.exports = ...` statements.

See original GitHub issue

visitTopLevelStatement calls rewriteModuleExportsAssignment, which transforms statements of the form module.exports = foo to exports = foo. However, it fails to do that same transformation if that statement is used to assign something else as well (e.g. var bar = module.exports = foo should get transformed to var bar = exports = foo, but does not)

Issue Analytics

State:
Created 3 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

evmarcommented, Nov 17, 2020

I think we don’t support commonjs in general, but only enough to massage TS’s commonjs output from ES module input. It’s not an intentional omission, we just have no TS code that uses commonjs directly.

0reactions

coreywoodfieldcommented, Nov 17, 2020

Ah okay. I just noticed that the first line was transformed but the second one wasn’t, which I figured was a bug. I assumed this would be supported because the code very deliberately replaces module.exports with exports, but not in all cases