esModuleInterop is not supported

When I run tsickle with esModuleInterop, tsickle produces the wrong javascript, with a regular require instead of goog.require.

Repro steps:

npm install typescript@~3.5.3 tsickle@0.37.0

I wish I could use tsickle 0.37.1, but unfortunally the npm package doesn’t have a binary (or a main.js file).

tsconfig.json:

{
  "compilerOptions": {
    "target": "es2017",
    "module": "commonjs",
    "strict": true,
    "esModuleInterop": true,
  }
}

a.ts:

import * as b from './b';

b.foo();

b.ts:

export function foo() {}

Generated a.js:

goog.module('a');
var module = module || { id: 'a.ts' };
const tsickle_b_1 = goog.requireType("b");
const b = __importStar(require("./b"));
b.foo();

If I don’t use import * as ... then the emitted JS is correct.

esModuleInterop is now one of the default flags generated when running tsc --init.

[Zamiell]

Any update on this issue? I’m sure tons of people out there would love to use tsickle with their TypeScript projects, but not supporting “esModuleInterop” seems to be a show-stopper.

In my particular case, my project has ES6-style import statements on JSON files, so it requires “esModuleInterop” to be set to true or it won’t even compile. As far as I know, this kind of this is the recommended solution / best practice for TypeScript, e.g. the highest upvoted answer here: https://stackoverflow.com/a/50830840

[rubenlg]

Somehow my comment disappeared from the thread. I tried tscc and got the same error.

Note that esModuleInterop is now one of the default flags when you use tsc --init, so this is going to be frustrating for people starting to use tsickle for the first time. Erroring on start for unsupported tsconfig flags sounds like a good first step.