Glob fails to link if there's only one file

When I try to use glob with only one file in the source directory, dotbot fails to create the link with “Nonexistent source for…”

- defaults:
    link:
      relink: true
      glob: true
      force: true
- link:
    ~/.config/broot: broot/*

.
├── broot
│   └── conf.hjson

❯ ./install 
Nonexistent source for ~/.config/broot : /home/jay/dotfiles/broot/*

==> Some tasks were not executed successfully

Adding a second file without changing anything else makes it function as expected. I would expect it to behave the same regardless of how many files are in the dir.

Why bother using glob if there’s only one file? Because it means if I add a second file later, I don’t need to also edit my install.conf.yaml. Almost always, I just want to symlink whatever is in the source directory. It took some squinting to even identify what was going wrong.

[eengstrom]

I can confirm this with a new test case I created, and that it worked as of the last tagged version (v.1.19.0), and failed after a patch (that I wrote) was merged into master. I will develop a fix.

[eengstrom]

I have a fix of a sort - line 73 of link.py goes from:

                elif len(glob_results) == 1 and destination[-1] != '/':

to

               elif len(glob_results) == 1 and (glob_results[0] == path):

… but I’m not sure the reason one would want to specify glob: true and yet not use any glob meta-chars. Essentially, the entire elif stanza seems like it hides errors in usage and tries to guess the/a right thing to do. The immediately preceding stanza does the same thing, but throws an error if the result is a directory.

Unless there is a clear use-case for allowing the use of glob: true and source path specifications without any glob meta-chars, I’d suggest always throwing an error.

I suppose the possible use case is when people want to put glob: true into a defaults block, but then again, the code is still hiding errors in use that aught to be corrected.

Looking for feedback.