cdv-electron-settings.json ignored

Bug Report

Maybe I misunderstood something, but no matter what I change in :

platform_www/cdv-electron-settings.json

e.g.:

{
    "browserWindow": {
        "height": 600,
        "webPreferences":{
            "devTools": false,
            "nodeIntegration": false
        },
        "width": 1000
    }
}

the command

cordova run electron

always uses it’s default values (and thus shows devtools). I can only avoid that, if I comment the line mainWindow.webContents.openDevTools(); in index.js

Am I missing something, or is this a bug?

Version information

Cordova 9.0.0 MacOS 10.14.4 node v11.7.0

Checklist

• [x ] I searched for existing GitHub issues
• [x ] I updated all Cordova tooling to most recent version
• [x ] I included all the necessary information above

[GedasGa]

I don’t think it’s gonna be swapped. The debug build is typically meant for debugging and it’s expected that users are probably going to use the Dev Tools. Plus, we use the same flags across other platforms in Cordova too.

You might be looking at the old documentation. To disable the build process you should use --nobuild flag.

cordova run electron --nobuild

Please, refer to the Cordova documentation.

[GedasGa]

We do not recommend modifying any files in the platform/ directory. Normally, the platform directory should never be committed to any versioning control service. Modifying will make platform upgrades impossible.

If you want to change the Electron’s browserWindow settings, we expect you to create a JSON file anywhere in a folder that is safe to be versioned, for example, res/electron, and then define the ElectronSettingsFilePath preference option to the config.xml file.

    <platform name="electron">
        <preference name="ElectronSettingsFilePath" value="res/electron/settings.json" />
    </platform>

However, with regards to the devTools option, we do not accept the user define value. This option is overridden by the Cordova CLI flag --debug (default) or --release.

If you do not want the Dev Tools visible, build or run with the --release flag.