question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Installer icon is not set when using a custom build configuration

See original GitHub issue

Bug Report

Problem

What is expected to happen?

Installer icon is set in the {project_root}/platforms/electron/build/builder-effective-config.yaml file when using a custom build configuration.

What does actually happen?

Installer icon is noot in the {project_root}/platforms/electron/build/builder-effective-config.yaml file, using default Electron icon.

Information

Command or Code

Using custom build configuration{project_root}/build.json:

{
  "electron": {
    "mac": {
      "package": [
        "tar.gz",
        "dmg",
        "zip"
      ],
      "arch": ["x64"]
    }
  }
}

Then building the application.

cordova build electron

Environment, Platform, Device

All platforms.

Version information

Codova v9.0.0 and Electron v1.0.2

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
GedasGacommented, Apr 19, 2019

Did you try to remove the existing platform folder? My guess is that you actually don’t have the changes. When you run just cordova platform update, it updates cordova-electron package in the node_modules folder. However, if you still have platforms/electron folder, it remains unchanged.

Try this:

cordova platform rm electron
cordova platform update 'electron@git://github.com/apache/cordova-electron.git#f0b9f8d749a2c17a6ce025a859ae595921df0160' --save
cordova platform add electron
0reactions
Polm90commented, Nov 29, 2022

I’m still having the issue with cordova-electron 3.1.0 and cordova 11.0.0.

How can I solve this issue?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Visual Studio Installer Project - shortcut icons not set
The application uses a custom icon, and it's correctly shown: exe file is displayed with the proper icon. I've created an Installer Project ......
Read more >
Run/debug configurations | GoLand Documentation
Learn how to use run configurations to run/debug your code in GoLand with various startup properties.
Read more >
Custom App Icons
The purpose of this guide is to walk through the process of generating and setting an app icon, as well as setting installer...
Read more >
install — CMake 3.25.1 Documentation
Specify a list of build configurations for which the install rule applies (Debug, Release, etc.). Note that the values specified for this option...
Read more >
Build Errors and Warnings
This build error occurs if your project contains a managed-code custom action for a standard DLL file. To resolve this error, replace the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found