All properties of DatabaseClusterAttributes should not be required

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository’s issues are intended for feature requests and bug reports.

• https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-rds.DatabaseClusterAttributes.html

• https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-rds.DatabaseCluster.html

• I’m submitting a …

  • 🪲 bug report
  • 🚀 feature request
  • 📚 construct library gap
  • ☎️ security issue or vulnerability => Please see policy
  • ❓ support request => Please see note at the top of this template.

• What is the current behavior? If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce

DatabaseCluster.from­Database­Cluster­Attributes() takes the DatabaseClusterAttributes interface as a props argument for filtering purposes. But, since every property of the interface is required, the method from­Database­Cluster­Attributes() not very useful.

• What is the expected behavior (or behavior of feature suggested)?

All properties of DatabaseClusterAttributes should be optional except for a few essential ones, if any.

• What is the motivation / use case for changing the behavior or adding this feature?

Currently, there is no way to refer to existing DB from CDK app. DatabaseCluster.from­Database­Cluster­Attributes() is the only one I’m aware of, but I cannot use it because all fields are required.

• Please tell us about your environment:

  • CDK CLI Version: 1.3.0 (build bba9914)
  • Module Version: 1.3.0
  • OS: OSX Mojave
  • Language: TypeScript

• Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)

[skinny85]

@kundkingan same ask as above 😉.

[tomjowitt]

I am still getting this error with the Go CDK:

cdk version
2.10.0 (build e5b301f)

	db := awsrds.DatabaseInstance_FromDatabaseInstanceAttributes(
		stack,
		jsii.String("xxxxRDSLookup"),
		&awsrds.DatabaseInstanceAttributes{
			InstanceIdentifier:      jsii.String("xxxxxxxx"),
		},
	)

Which results in the error:

panic: "Missing required properties for monocdk.aws_rds.DatabaseInstanceAttributes: instanceEndpointAddress, port, securityGroups"

I also tried adding nil values which didn’t fix it.

	db := awsrds.DatabaseInstance_FromDatabaseInstanceAttributes(
		stack,
		jsii.String("xxxxRDSLookup"),
		&awsrds.DatabaseInstanceAttributes{
			InstanceEndpointAddress: nil,
			InstanceIdentifier:      jsii.String("xxxxxxxx"),
			Port:                    nil,
			SecurityGroups:          nil,
		},
	)