(core): Nested Stacks have a crazy logical ID

What is the problem?

Recently, we found out the construct id of the nested stack occurred twice in its logical id.

For example:

##### Parent infra stack ##### 
this.fdLifecycleCommonLambdas = new MyNestedStackConstruct(this, "MyNestedStackConstruct", {
 ...
 });
 
 
#### Nested stack #####
export class MyNestedStackConstruct extends NestedStack {
    ...
    constructor(parent: Construct, name: string, props: FdLifecycleCommonLambdasProps) {
        super(parent, name);
    }
    ...
}

#### Generated template ####
...
"Resources": {
    "MyNestedStackConstructNestedStackMyNestedStackConstructNestedStackResource3E193B32": {
            ^^^^^^^^^^^ oh no                                   ^^^^^^^^^^^^^^^^^^^^^^^
      "Type": "AWS::CloudFormation::Stack",
      "Properties": {}
    ...
}

Caused by the code here:

https://github.com/aws/aws-cdk/blob/2b6c2dadc039f7c4255f6864386ba1dd28b6fc4f/packages/%40aws-cdk/core/lib/nested-stack.ts#L123-L133

[konstantinj]

re-posting my temporary solution for this here:

    getLogicalId(element: CfnElement): string {
        if (element.node.id.includes('NestedStackResource')) {
            return /([a-zA-Z0-9]+)\.NestedStackResource/.exec(element.node.id)![1] // will be the exact id of the stack
        }
        return super.getLogicalId(element)
    }

Place this inside your nested stacks to get a normal name like: ParentStackName-NestedStackName-LWJUNJMGDHO7

[RobReus]

Is there anything happening on this issue? The crazy long names is bad as it is, but when doing a cross stack parameter reference between 2 nested stacks, the resulting parameter name is even crazier. Its currently not breaking anything for me, but I can’t imagine this naming behavior is intended.