[ecs] unable to specify update policy when adding ASG capacity to ECS cluster

The following code forces the updateType prop when constructing the subsequent ASG cluster:

https://github.com/aws/aws-cdk/blob/0b058f372a41092a383706dc35e32e0573b962fe/packages/%40aws-cdk/aws-ecs/lib/cluster.ts#L203

The updateType prop is of type UpdateType which is now deprecated in favor of passing an UpdatePolicy but the two arguments are mutually exclusive. If you try to pass an updatePolcy prop into this function, the following error is output:

Error: Cannot set 'signals'/'updatePolicy' and 'updateType' together. Prefer 'signals'/'updatePolicy'

The only way for callers to override the default is to supply an updateType prop to override the Cluster’s default behavior when using .addCapacity(...). This means the caller must use a deprecated API which is not ideal and causes linter warnings unless they are dismissed/disabled.

I believe this could be fixed by making this wrapper method aware of the mutually-exclusive props and if neither is specified, pass updatePolicy: UpdatePolicy.rollingUpdate().

[solovievv]

My solution for python CDK:

        auto_scaling_group = cluster.add_capacity(...)
        cfn_asg_resource = auto_scaling_group.node.default_child
        cfn_asg_resource.add_override(
            path="UpdatePolicy",
            value={
                "AutoScalingRollingUpdate": {
                    "MinInstancesInService": "2",
                    "MaxBatchSize": "1",
                    "PauseTime": "PT10M0S",
                    "WaitOnResourceSignals": "false",
                    "SuspendProcesses": [
                        "HealthCheck",
                        "ReplaceUnhealthy",
                        "AZRebalance",
                        "AlarmNotification",
                        "ScheduledActions"
                    ]
                }
            }
        )
        cfn_asg_resource.add_deletion_override("UpdatePolicy.AutoScalingReplacingUpdate")
        cfn_asg_resource.add_deletion_override("UpdatePolicy.AutoScalingScheduledAction")

[evayde]

If you came here from google, this would work:

    this.cluster.addCapacity("AppCap", {
      ...
      updateType: undefined,
      updatePolicy: autoscaling.UpdatePolicy.rollingUpdate(),
    });