(logs): delete associated log group when stack is deleted

When the log group of a Lambda function is created by the LogRetention custom resource, then those log groups linger after the stack has been deleted. It should be possible to configure the removal policy.

Use Case

Not having hundreds of dead log groups around, created for PR and test deployments.

Proposed Solution

This requires setting the deletionPolicy on the CfnResource, and implementing support for the “Delete” event type in the custom resource itself.

Other

N/A

• 👋 I may be able to implement this feature request
• ⚠️ This feature might incur a breaking change

---

This is a 🚀 Feature Request

[shishkin]

We could add this feature on the LogRetention construct and updating the handler with the Delete event.

Yes, LogRetention needs a RemovalPolicy that when set to DESTROY would delete the log group.

[greensmith]

Another alternative is changing policies on the role to deny log access , to stop them being created in the first place. e.g. for BucketDeployment, if we’re deploying/destroying multiple dev branches i’d rather not have to worry about going in and tidying up after a destroy than having 99/100 logs saying the zip contents were extracted successfully.

const BucketDeploymentHandler = this.bucketDeployment.node.findChild('CustomResourceHandler') as SingletonFunction;
        BucketDeploymentHandler.addToRolePolicy(new PolicyStatement({
            actions:['logs:*'],
            resources:['*'],
            effect: Effect.DENY
       })
)