Generated createClient method does not use all parameters for parameterized host

When using a parameterized host with multiple parts, the TS autorest client will only include parameters in the createClient method for one of the parts.

This impacts the PR and linked spec here.

Our parameterized host looks like the following:

“{tenantId}-{resourceName}.{dnsSuffix}”.

The expected createClient method would looks like the following:

export default function createClient(
  tenantId: string,
  devCenter: string,
  credentials: TokenCredential,
  devCenterDnsSuffix: string = "devcenter.azure.com",
  options: ClientOptions = {}
): AzureDevCenterClient {
  const baseUrl = options.baseUrl ?? `https://${tenantId}-${devCenter}.${devCenterDnsSuffix}`;

The actual method is as follows:

export default function createClient(
  tenantId: string,
  credentials: TokenCredential,
  options: ClientOptions = {}
): AzureDevCenterClient {
  const baseUrl = options.baseUrl ?? `https://${tenantId}-{devCenter}.{devCenterDnsSuffix}`;

autorest.typescript version is 6.0.0-rc.1

This generates an unusable createClient method, blocking use of the package. Happy to help investigate or provide more info as needed!

[chrissmiller]

@MaryGao rc.2 fixes this issue for us, thank you so much! We are noticing a second issue withe the parameterized host in createClient though – we have a default value for one of the host parameters, and the default value is not provided. We have manually fixed this for our PR, let me know if there is a fix we can consume instead though!

So rather than the expected output, we get:

export interface AzureDevCenterClientOption extends ClientOptions {
   devCenterDnsSuffix: string;
}

export default function createClient(
  tenantId: string,
  devCenter: string,
  credentials: TokenCredential,
  options: ClientOptions = {}
): AzureDevCenterClient { 
  // Handle the default value here
}

Link to the spec doc: https://github.com/Azure/azure-rest-api-specs/blob/75a8d8dcc9f6d0ec626bdeb32f5154f20c8c61cd/specification/devcenter/data-plane/Microsoft.DevCenter/preview/2022-03-01-preview/devcenter.json

[MaryGao]

Close this issue considering the issue resolved. Feel free to reopen it if necessary!